RFR: 8350824: New async logging gtest StallingModePreventsDroppedMessages fails [v2]

[David Holmes]

On Thu, 27 Feb 2025 09:33:30 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> When I added async stalling mode I also added this gtest early in the process, and as tier1/GHA passed I did not look at the test again. However, the test does not run until much deeper in the CI/CD process for us, as that's when we turn on async logging explicitly for all gtests.
>> 
>> Looking at it now, it's clearly buggy. It doesn't check which async mode UL is in, and as `drop` is default, that makes it bound to fail. Besides, the goal of it is to check whether async stalling mode drops messages or not during stress. We already have an excellent test for that in JTReg, and this does run early as it spawns its own VM with the correct asynchronous mode specified. My suggested fix is to delete the gtest and add a dropped message check to the JTReg test instead.
>> 
>> Testing: StressAsyncUL.java, GHA
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   bool in C++, boolean in Java, great :-)

Seems okay.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23819#pullrequestreview-2649480617