RFR: 8350916: Remove misleading warning "Cannot dump shared archive while using shared archive"

[Calvin Cheung]

On Fri, 28 Feb 2025 02:10:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this trivial change. I replaced an unreachable `warning()` call with an assert and an explanation in comments.
> 
> I verified with running all CDS tests and the assert is never triggered.

One typo. Looks good otherwise.

src/hotspot/share/cds/cdsConfig.cpp line 72:

> 70:   if (is_dumping_static_archive() && !is_dumping_final_static_archive()) {
> 71:     // Note: -Xshare and -XX:AOTMode flags are mutually exclusive.
> 72:     // - Class workflow: -Xshare:on and -Xshare:dump cannot take effect at the same time.

s/Class/Classic

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23836#pullrequestreview-2649964192
PR Review Comment: https://git.openjdk.org/jdk/pull/23836#discussion_r1974935296