RFR: 8350916: Remove misleading warning "Cannot dump shared archive while using shared archive" [v2]

[Calvin Cheung]

On Fri, 28 Feb 2025 16:04:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this trivial change. I replaced an unreachable `warning()` call with an assert and an explanation in comments.
>> 
>> I verified with running all CDS tests and the assert is never triggered.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @calvinccheung comment - fixed typo

Marked as reviewed by ccheung (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23836#pullrequestreview-2651184623