RFR: 8332506: SIGFPE In ObjectSynchronizer::is_async_deflation_needed() [v2]
Fredrik Bredberg
fbredberg at openjdk.org
Thu Jan 2 14:47:38 UTC 2025
On Sun, 22 Dec 2024 20:36:35 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> The transformation using delta is the idiomatic way to convert potentially overflowing (and possibly UB) expressions into a conditional operation that avoids overflow. As Coleen states neither form is generally obvious to all readers.
>
> I'd prefer to see any change to when/why the ceiling is adjusted deferred to the issue that looks at what it should be adjusted to. Nothing about this ceiling is intuitive or obvious to me.
Changed the code to use @dholmes-ora delta/overflow method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22815#discussion_r1900947832
More information about the hotspot-runtime-dev
mailing list