RFR: 8332506: SIGFPE In ObjectSynchronizer::is_async_deflation_needed() [v2]
Fredrik Bredberg
fbredberg at openjdk.org
Sun Jan 5 15:18:21 UTC 2025
On Fri, 3 Jan 2025 18:32:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update after review
>
> src/hotspot/share/runtime/synchronizer.cpp line 1279:
>
>> 1277: size_t monitor_usage = (monitors_used * 100LL) / ceiling;
>> 1278: if (int(monitor_usage) > MonitorUsedDeflationThreshold) {
>> 1279: bool status = true;
>
> Above this, can you add a comment that's something like:
> // Deflate monitors if over the threshold percentage unless no progress on previous deflations
>
> Maybe rename 'status' to be 'is_above_threshold' would be more meaningful.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22815#discussion_r1903290750
More information about the hotspot-runtime-dev
mailing list