RFR: 8332506: SIGFPE In ObjectSynchronizer::is_async_deflation_needed() [v3]

Fredrik Bredberg fbredberg at openjdk.org
Mon Jan 6 18:35:43 UTC 2025


On Mon, 6 Jan 2025 01:41:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update two after review
>
> src/hotspot/share/runtime/synchronizer.cpp line 1288:
> 
>> 1286:         _no_progress_cnt >= NoAsyncDeflationProgressMax) {
>> 1287:       double remainder = (100.0 - MonitorUsedDeflationThreshold) / 100.0;
>> 1288:       size_t delta = (size_t)((double)ceiling * remainder) + 1;
> 
> Suggestion:
> 
>       size_t delta = (size_t)(ceiling * remainder) + 1;

The original source (before this PR) had the `(double)` cast, and I wanted to keep the diff as short as possible. It really doesn't matter since `remainder` is of type `double`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22815#discussion_r1904498836


More information about the hotspot-runtime-dev mailing list