RFR: 8332506: SIGFPE In ObjectSynchronizer::is_async_deflation_needed() [v3]

[Fredrik Bredberg]

On Tue, 7 Jan 2025 06:09:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yeah well, sorry but I don't get the new math or the old math and we now seem to have a change in behaviour, the affect of which I can't gauge.
>
> That said, after further analysis I think you are right in this change. The whole point of the NoAsyncDeflationProgressMax logic is to throttle useless deflation cycles when we exceed the ceiling but they are all in-use so there's nothing getting deflated. So to address that we increase the ceiling (by a calculation that makes no sense to me and doesn't seem to be described). As the new ceiling is normally > than the old (and at worst clamped to the same value) then the `monitor_usage` fraction will have decreased, and if that is now below the threshold then we should return false, not true, as a deflation cycle is not wanted now.

Yeah, that's my view as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22815#discussion_r1905175596