RFR: 8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
Fei Yang
fyang at openjdk.org
Tue Jan 7 10:34:46 UTC 2025
On Mon, 30 Dec 2024 11:15:11 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:
>> Hi, Please review this small change.
>>
>> On the crash site, we are invoking the `SharedRuntime::dsin` C++ routine with `call(address)`. After [JDK-8343242](https://bugs.openjdk.org/browse/JDK-8343242), `call(address)` won't check the range. It emits `auipc + jalr` sequence and thus expects intra code cache targets, which is not the case for these callsites. For targets outside of the code cache, we should use the `rt_call` assembler routine which performs necessary check about the target.
>>
>> Testing: Same test passes with fastdebug build on Premier P550 SBC.
>
> Marked as reviewed by fjiang (Committer).
@feilongjiang @robehn : Thanks for the review!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22884#issuecomment-2574938142
More information about the hotspot-runtime-dev
mailing list