Integrated: 8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
Fei Yang
fyang at openjdk.org
Tue Jan 7 10:34:46 UTC 2025
On Thu, 26 Dec 2024 03:25:17 GMT, Fei Yang <fyang at openjdk.org> wrote:
> Hi, Please review this small change.
>
> On the crash site, we are invoking the `SharedRuntime::dsin` C++ routine with `call(address)`. After [JDK-8343242](https://bugs.openjdk.org/browse/JDK-8343242), `call(address)` won't check the range. It emits `auipc + jalr` sequence and thus expects intra code cache targets, which is not the case for these callsites. For targets outside of the code cache, we should use the `rt_call` assembler routine which performs necessary check about the target.
>
> Testing: Same test passes with fastdebug build on Premier P550 SBC.
This pull request has now been integrated.
Changeset: 379ac349
Author: Fei Yang <fyang at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/379ac349d13e2c0c6986eb0787f33b9a7a2a3749
Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
Reviewed-by: fjiang, rehn
-------------
PR: https://git.openjdk.org/jdk/pull/22884
More information about the hotspot-runtime-dev
mailing list