RFR: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer [v9]
SendaoYan
syan at openjdk.org
Wed Jan 8 02:19:17 UTC 2025
On Tue, 7 Jan 2025 21:32:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rewrite function HeapReserver::Instance::try_reserve_range for avoid calculation addresses outside of the range
>
> src/hotspot/share/memory/memoryReserver.cpp line 435:
>
>> 433: const uint64_t num_attempts_possible = (attach_range / attach_point_alignment) + 1;
>> 434: const uint64_t num_attempts_to_try = MIN2((uint64_t)HeapSearchSteps, num_attempts_possible);
>> 435: const uint64_t num_intervals = num_attempts_to_try - 1;
>
> pre-existing, but stands out more now. Why the introduction of uint64_t in here? It seems like this should
> just be using size_t throughout.
Thanks, size_t if more general than uint64_t. uint64_t has been replaced as size_t.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22897#discussion_r1906249586
More information about the hotspot-runtime-dev
mailing list