RFR: 8346834: Tests failing with -XX:+UseNUMA due to "NUMA support disabled" warning

David Holmes dholmes at openjdk.org
Wed Jan 8 04:38:38 UTC 2025


On Tue, 7 Jan 2025 13:46:16 GMT, Swati Sharma <duke at openjdk.org> wrote:

> Hi All,
> 
> A number of tests launch VMs and read the output of the sub-process. The changes in [JDK-8205051](https://bugs.openjdk.org/browse/JDK-8205051) mean the warning message "NUMA support disabled: Only a single NUMA node is available" is printed when running the tests -XX:+UseNUMA on system that only have one node, this breaks several tests. After update in some tests, so far, the failures are with:
> 
> java/util/logging/LoggingDeadlock2.java
> tools/jar/modularJar/Basic.java
> 
> As a fix have changed logging level from "log_warning" to "log_info" when UseNUMA flag is disabled. 
> 
> Thanks,
> Swati Sharma
> Intel

Changes requested by dholmes (Reviewer).

src/hotspot/os/linux/os_linux.cpp line 4540:

> 4538:       (UseNUMAInterleaving && FLAG_IS_CMDLINE(UseNUMAInterleaving))) {
> 4539:     // Only issue a warning if the user explicitly asked for NUMA support
> 4540:     log_info(os)("NUMA support disabled: %s", reason);

So this is too coarse. Some reasons for disabling NUMA may require a warning because something is actually wrong. I only want to see the new warning for "Only a single NUMA node is available" not be a warning.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22948#pullrequestreview-2535978483
PR Review Comment: https://git.openjdk.org/jdk/pull/22948#discussion_r1906457404


More information about the hotspot-runtime-dev mailing list