RFR: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached"

[Johan Sjölen]

On Mon, 6 Jan 2025 09:33:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

> This bug was introduced by [JDK-8252921](https://bugs.openjdk.org/browse/JDK-8252921) which moved the unregister call from the thread destructor (because it was not called for all threads) to the post_run() method. But this totally overlooked native threads that attach and detach! This is easily fixed by moving the unregister call to the end of JavaThread::exit.
> 
> We also update the ProblemList and disable -Xcheck:JNI for a test that does actually terminate threads without detaching.
> 
> Testing: tiers 1-4
> 
> Thanks.

LGTM, thank you for your work on this.

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22924#pullrequestreview-2536831965