RFR: 8346929: runtime/ClassUnload/DictionaryDependsTest.java fails with "Test failed: should be unloaded" [v2]

[Coleen Phillimore]

On Wed, 8 Jan 2025 19:13:09 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed @calvincheung comments.
>
> test/hotspot/jtreg/runtime/cds/appcds/customLoader/test-classes/HelloUnload.java line 107:
> 
>> 105:             Set<String> aliveClasses = ClassUnloadCommon.triggerUnloading(List.of(className));
>> 106:             System.out.println("Is CustomLoadee alive? " + wb.isClassAlive(className));
>> 107:             ClassUnloadCommon.failIf(!aliveClasses.isEmpty(), "should have bee unloaded: " + aliveClasses);
> 
> typo: bee -> been

Fixed.

> test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java line 45:
> 
>> 43: import java.util.Collections;
>> 44: import java.util.List;
>> 45: import java.util.Set;
> 
> This seems to be unused. Or perhaps should check the return `Set<String>` from the call to `ClassUnloadCommon.triggerUnloading` below as is being done in other tests?

The test didn't check that the className was unloaded with WhiteBox only with the logging message, so we don't need the return Set type.  I removed this import.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22974#discussion_r1907848094
PR Review Comment: https://git.openjdk.org/jdk/pull/22974#discussion_r1907849056