RFR: 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region [v12]

[Matias Saavedra Silva]

On Thu, 9 Jan 2025 16:00:54 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed comment
>
> src/hotspot/share/cds/filemap.cpp line 1895:
> 
>> 1893:   assert(requested_addr != nullptr, "must be specified");
>> 1894: 
>> 1895:   r->set_mapped_from_file(false);
> 
> Need to add `r->set_in_reserved_space(false);` here, as the `r` can be used twice (first map at requested location; if that fails, map at random location).

Does that belong here or should it be placed in `init()`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22743#discussion_r1909087185