Integrated: 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region

[Matias Saavedra Silva]

On Fri, 13 Dec 2024 19:51:47 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> What testing with `UseCompressedClassPointers` set to false, this assert is hit due to memory being released twice during the failure path of CDS archive mapping. This patch makes it so the RW and RO regions are only released once at the end in `MetaspaceShared::release_reserved_spaces()`. 
> 
> This patch hides `unmap_region` as the method should not be called on regions that were reserved. Instead, the region is skipped and we verify that it is indeed in the reserved space. Verified` with tier 1-4 tests.

This pull request has now been integrated.

Changeset: 931914af
Author:    Matias Saavedra Silva <matsaave at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/931914af76932c9b91fc9affd55d24b2562c72d2
Stats:     27 lines in 3 files changed: 18 ins; 2 del; 7 mod

8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region

Reviewed-by: iklam, jsjolen, stefank

-------------

PR: https://git.openjdk.org/jdk/pull/22743