RFR: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached" [v3]

David Holmes dholmes at openjdk.org
Fri Jan 10 01:47:20 UTC 2025


> This bug was introduced by [JDK-8252921](https://bugs.openjdk.org/browse/JDK-8252921) which moved the unregister call from the thread destructor (because it was not called for all threads) to the post_run() method. But this totally overlooked native threads that attach and detach! This is easily fixed by moving the unregister call to the end of JavaThread::exit.
> 
> We also update the ProblemList and disable -Xcheck:JNI for a test that does actually terminate threads without detaching.
> 
> Testing: tiers 1-4
> 
> Thanks.

David Holmes has updated the pull request incrementally with one additional commit since the last revision:

  Fix order of unregister and smr_delete

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22924/files
  - new: https://git.openjdk.org/jdk/pull/22924/files/4bd26648..0f0cbbf2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22924&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22924&range=01-02

  Stats: 2 lines in 2 files changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22924.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22924/head:pull/22924

PR: https://git.openjdk.org/jdk/pull/22924


More information about the hotspot-runtime-dev mailing list