RFR: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached" [v3]

[David Holmes]

On Fri, 10 Jan 2025 13:45:06 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix order of unregister and smr_delete
>
> This looks good.  It makes sense and keeps things together.  It's sort of unfortunate to repeat the NMT unregistration but smr_delete is also repeated and if there's another thread shutdown action needed outside of exit() we know where to add it (and if there are a lot we could evolve to have some other wrapper for these actions).

Thanks for the review @coleenp !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22924#issuecomment-2585942863