RFR: 8347434: Richer VM operations events logging

[David Holmes]

On Fri, 10 Jan 2025 15:08:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> A simpler quality of diagnostics improvement. In hs_err, it is not abundantly clear if executed VM operations took safepoint or not, were nested or not. It would be good to print that out.

A couple of suggestions but I'll approve anyway.

src/hotspot/share/runtime/vmThread.cpp line 411:

> 409:            cause != nullptr ? " (" : "",
> 410:            cause != nullptr ? cause : "",
> 411:            cause != nullptr ? ")" : "");

Might be a little cleaner to use a separate print statement only if cause is not null.

src/hotspot/share/runtime/vmThread.cpp line 413:

> 411:            cause != nullptr ? ")" : "");
> 412: 
> 413:   EventMarkVMOperation em("%s",ss.freeze());

Suggestion:

  EventMarkVMOperation em("%s", ss.freeze());

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23039#pullrequestreview-2545843733
PR Review Comment: https://git.openjdk.org/jdk/pull/23039#discussion_r1912741025
PR Review Comment: https://git.openjdk.org/jdk/pull/23039#discussion_r1912742282