RFR: 8340416: Remove ArchiveBuilder::estimate_archive_size() [v2]

[Sonia Zaldana Calles]

On Mon, 13 Jan 2025 17:33:49 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Adding buffer size for 32-bit
>>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8340416
>>  - 8340416: Remove ArchiveBuilder::estimate_archive_size()
>
> src/hotspot/share/cds/archiveBuilder.cpp line 306:
> 
>> 304: 
>> 305: address ArchiveBuilder::reserve_buffer() {
>> 306:   size_t buffer_size = CompressedClassSpaceSize;
> 
> CompressedClassSpaceSize is 1G by default. On 32-bit platforms, it may be difficult to reserve that much space. I think we should do this:
> 
> 
> size_t buffer_size = LP64_ONLY() NOT_LP64(256 * M);
> 
> 
> The 256M size is close to how much we were reserving on 32-bit.

Thanks @iklam ! I made the changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21931#discussion_r1913692800