RFR: 8340416: Remove ArchiveBuilder::estimate_archive_size() [v2]

Ioi Lam iklam at openjdk.org
Mon Jan 13 22:57:46 UTC 2025


On Mon, 13 Jan 2025 18:49:25 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi folks, 
>> 
>> This PR removes ArchiveBuilder::estimate_archive_size() per the issues raised in [JDK-8340416](https://bugs.openjdk.org/browse/JDK-8340416). 
>> 
>> Thanks!
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Adding buffer size for 32-bit
>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8340416
>  - 8340416: Remove ArchiveBuilder::estimate_archive_size()

Please remove these members from ArchiveBuilder as well.


  // Conservative estimate for number of bytes needed for:
  size_t _estimated_metaspaceobj_bytes;   // all archived MetaspaceObj's.
  size_t _estimated_hashtable_bytes;     // symbol table and dictionaries
  ...
  void verify_estimate_size(size_t estimate, const char* which);

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21931#issuecomment-2588398763


More information about the hotspot-runtime-dev mailing list