RFR: 8347143: [aix] Fix strdup use in os::dll_load [v3]
Kim Barrett
kbarrett at openjdk.org
Tue Jan 14 05:04:40 UTC 2025
On Mon, 13 Jan 2025 17:12:00 GMT, Joachim Kern <jkern at openjdk.org> wrote:
>> The use of strdup (which is os::strdup because of context) in aix's os::dll_load is odd. The result is nearly unused (it's passed to strrchr, but the original filename could be used instead), so the duplication doesn't seem needed. And the duplicate is free'd using FREE_C_HEAP_ARRAY, which seems wrong.
>
> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>
> Cosmetic changes
Still good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23078#pullrequestreview-2548815594
More information about the hotspot-runtime-dev
mailing list