RFR: 8347143: [aix] Fix strdup use in os::dll_load [v4]

Kim Barrett kbarrett at openjdk.org
Tue Jan 14 09:41:46 UTC 2025


On Tue, 14 Jan 2025 09:15:22 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> The use of strdup (which is os::strdup because of context) in aix's os::dll_load is odd. The result is nearly unused (it's passed to strrchr, but the original filename could be used instead), so the duplication doesn't seem needed. And the duplicate is free'd using FREE_C_HEAP_ARRAY, which seems wrong.
>
> Joachim Kern has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge master
>  - Cosmetic changes
>  - Copyright dates
>  - JDK-8347143

Marked as reviewed by kbarrett (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23078#pullrequestreview-2549225507


More information about the hotspot-runtime-dev mailing list