RFR: 8346433: Cannot use DllMain in hotspot for static builds [v2]

[Magnus Ihse Bursie]

On Tue, 14 Jan 2025 05:45:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into dll-main-in-hotspot
>>  - Add explanation
>>  - Update comments and copyright year
>>  - Restore DllMain
>>  - 8346433: Cannot use DllMain in hotspot for static builds
>
> src/hotspot/os/windows/symbolengine.hpp line 61:
> 
>> 59:   void print_state_on(outputStream* st);
>> 60: 
>> 61:   // Called as early as possible
> 
> Suggestion:
> 
> // Called  at DLL_PROCESS_ATTACH for dynamic builds, and from os::init() for static builds.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22793#discussion_r1914598408