RFR: 8347531: The signal tests are failing after JDK-8345782 due to an unrelated warning

Kevin Walls kevinw at openjdk.org
Tue Jan 14 13:47:44 UTC 2025


On Tue, 14 Jan 2025 13:14:59 GMT, Joakim Nordström <jnordstrom at openjdk.org> wrote:

> Could I get a review of this fix for the SigTestDriver test?
> 
> This fix adds more context from the libjsig deprecation warning to only catch the correct scenario in the test.
> 
> Previously the test only checked for the words `VM warning` in the output to determine the deprecation warning was present. However, another VM Warning printed when running a flag on an unsupported platform made the SigTestDriver fail incorrectly (`VM warning: -XX:+UseLargePages not supported in this VM`).
> 
> ## Testing
> * [x] Verified test still succeeds in "normal" way
> * [x] Verified test also succeeds despite having the other warning.
> * [ ] Tested tier1-tier3

Looks good, is enough to remove the confusion with other VM messages.

-------------

Marked as reviewed by kevinw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23103#pullrequestreview-2549743218


More information about the hotspot-runtime-dev mailing list