RFR: 8346433: Cannot use DllMain in hotspot for static builds [v3]

Thomas Stuefe stuefe at openjdk.org
Tue Jan 14 15:23:39 UTC 2025


On Tue, 14 Jan 2025 15:11:18 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 4436:
>> 
>>> 4434: }
>>> 4435: 
>>> 4436: HMODULE GetHotspotModuleHandle() {
>> 
>> No need to export this.
>
> Actually, that is kind of the point of this function, so it can be used to look up where it resides.

Oh right, I missed that. 

But you can just use GetModuleHandle(NULL) then. 

"If this parameter is NULL, GetModuleHandle returns a handle to the file used to create the calling process (.exe file)."

No need to needlessly export a symbol.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22793#discussion_r1915027586


More information about the hotspot-runtime-dev mailing list