RFR: 8345543: Test serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java failed: expected JVMTI_ERROR_OPAQUE_FRAME instead of: 0

[Patricio Chilano Mateo]

On Wed, 15 Jan 2025 07:48:07 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The problem is that the state of the target `vthread` is changed to `BLOCKED` too early. It is done in a constructor of helper object `JavaThreadBlockedOnMonitorEnterState` which sets the state of `vthread` to `JavaThreadStatus::BLOCKED_ON_MONITOR_ENTER`. The `vthread` is getting suspended in `try_preempt()` while calling `JvmtiVTMSTransitionDisabler::start_VTMS_transition()`, so does not become unmounted as it is expected by the failing test. Also, it seems that the base class of the `JavaThreadBlockedOnMonitorEnterState` is supporting just HotSpot  `JavaThread`'s and so, it is changing the carrier thread state only.
> 
> The fix is to move the definition of the `JavaThreadBlockedOnMonitorEnterState` object after block where `try_preempt()` is called.
> 
> Testing:
>  - Checked the failed test does not fail with the fix: `serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java`
>  - Ran mach5 tiers 1-6

Looks good to me.

src/hotspot/share/runtime/objectMonitor.cpp line 495:

> 493:   freeze_result result;
> 494: 
> 495:   {

I think we should move this curly brace down too.

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23125#pullrequestreview-2553250111
PR Review Comment: https://git.openjdk.org/jdk/pull/23125#discussion_r1916956212