RFR: 8347758: modules.cpp leaks string returned from get_numbered_property_as_sorted_string() [v4]

Calvin Cheung ccheung at openjdk.org
Wed Jan 15 22:17:37 UTC 2025


On Wed, 15 Jan 2025 19:22:50 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Modules::get_numbered_property_as_sorted_string() returns strings created from os::strdup(), callers should free them after uses.
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Assertion in wrong place

Thanks for the update.
I'm running some tiers testing and will report back once they are done, hopefully by tomorrow.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23121#pullrequestreview-2554133872


More information about the hotspot-runtime-dev mailing list