RFR: 8345543: Test serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java failed: expected JVMTI_ERROR_OPAQUE_FRAME instead of: 0 [v4]

[Alan Bateman]

On Thu, 16 Jan 2025 23:05:50 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> Thank you for the comment and the suggestion. It'd be nice to to make this correct including JVMTI spec clarification. My preference now is to go satisfy the David's suggestion to retain the long standing behavior for this (current) fix and change this behavior in a following separate fix with a spec clarification and a CSR filed. 

I don't have an opinion on the sequencing but it is clear that there is some technical debt here, and kinda surprising that the issue of thread states when invoking JVMTI callbacks hasn't caused problems already. It may be useful to create a test case that upcalls to Java code in the live phase from all JVMTI callbacks that have a JNIEnv parameter. If done in the blocked state it would be interesting to see how far it gets before tripping up on an assert or guarantee. It's possible that such an experiment will identity cases where the spec should warn not to do this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23125#issuecomment-2597581962