RFR: 8345543: Test serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java failed: expected JVMTI_ERROR_OPAQUE_FRAME instead of: 0 [v5]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Jan 17 07:57:37 UTC 2025
On Fri, 17 Jan 2025 06:36:33 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review: preserve platform thread behavior
>
> src/hotspot/share/runtime/objectMonitor.hpp line 393:
>
>> 391: bool try_enter(JavaThread* current, bool check_for_recursion = true);
>> 392: bool spin_enter(JavaThread* current);
>> 393: void notify_contended_enter(JavaThread *current);
>
> This helper method should be private. Thanks
Thanks. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23125#discussion_r1919699243
More information about the hotspot-runtime-dev
mailing list