RFR: 8346792: serviceability/jvmti/vthread/GetThreadState/GetThreadState.java testObjectWaitMillis failed [v7]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Jan 22 11:26:48 UTC 2025
On Mon, 20 Jan 2025 02:11:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>>
>> - Merge
>> - review: preserve platform thread behavior
>> - review: add some useful comments
>> - review: restored the current->set_current_waiting_monitor(this) position as it was originally
>> - review: move set_current_waiting_monitor down; cleanup DBG ifdefs
>> - removed empty line with trailing spaces
>> - review: refix with a new constructor arg: iterruptible
>> - 8346792: serviceability/jvmti/vthread/GetThreadState/GetThreadState.java testObjectWaitMillis failed
>
> src/hotspot/share/prims/jvm.cpp line 629:
>
>> 627: JVM_ENTRY(void, JVM_MonitorWait(JNIEnv* env, jobject handle, jlong ms))
>> 628: Handle obj(THREAD, JNIHandles::resolve_non_null(handle));
>> 629: JavaThreadInObjectWaitState jtiows(thread, ms != 0);
>
> This is still changing the behaviour for non-virtual threads.
Thanks. Yes, that is right. Will make one more update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23126#discussion_r1925156292
More information about the hotspot-runtime-dev
mailing list