RFR: 8323807: Async UL: Add a stalling mode to async UL [v10]

Johan Sjölen jsjolen at openjdk.org
Thu Jan 23 07:23:48 UTC 2025


On Thu, 23 Jan 2025 03:41:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   NOT_DEBUG is not the same as PRODUCT_ONLY I assume
>
> src/hotspot/share/logging/logAsyncWriter.hpp line 221:
> 
>> 219:                                      const char* msg);
>> 220:   static bool enqueue_if_initialized(LogFileStreamOutput& output,
>> 221:                                      LogMessageBuffer::Iterator msg_iterator);
> 
> Are these really part of the public API? Couldn't the additional logic just be folded into the enqueue method?

Hm, yeah, we can fold it into the `enqueue` methods since they basically do nothing as is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22770#discussion_r1926482360


More information about the hotspot-runtime-dev mailing list