RFR: 8323807: Async UL: Add a stalling mode to async UL [v10]

David Holmes dholmes at openjdk.org
Fri Jan 24 05:37:52 UTC 2025


On Thu, 23 Jan 2025 07:52:24 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/logging/logAsyncWriter.cpp line 309:
>> 
>>> 307:   AsyncLogWriter* instance = AsyncLogWriter::instance();
>>> 308:   if (instance != nullptr) {
>>> 309:     if ((uintptr_t)instance == (uintptr_t)Thread::current_or_null()) {
>> 
>> Why the casts ??
>
> Sorry, that was sloppy of me. I still need a cast, but to the proper `Thread` type.

Why do you need a cast to `Thread`? `AsyncLogWriter` is-a NonJavaThread is-a `Thread`. `Thread::current_or_null()` returns a `Thread`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22770#discussion_r1928111441


More information about the hotspot-runtime-dev mailing list