RFR: 8346792: serviceability/jvmti/vthread/GetThreadState/GetThreadState.java testObjectWaitMillis failed [v9]

[Serguei Spitsyn]

On Fri, 24 Jan 2025 12:24:26 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> src/hotspot/share/runtime/objectMonitor.cpp line 1653:
>> 
>>> 1651: }
>>> 1652: 
>>> 1653: void ObjectMonitor::post_monitor_wait(JavaThread *current, jlong millis) {
>> 
>> Not sure this is worthwhile factoring out for a few reasons:
>> 1. the actual code is only 2 lines
>> 2.  the comment only makes sense when a path that will park follows this code - which is now only one of the three cases
>> 3.  It is confusing to see this method and the static `post_monitor_wait_event`
>> 
>> I think we can just inline the code where needed and place the comment after L1725 (as I don't think it even applies to the virtual thread case prior to that).
>
> Thanks. Good suggestion, I've updated the fix, mach5 tiers are in progress.

Mach5 tiers 1-6 are good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23126#discussion_r1930188640