RFR: 8333522: JFR SwapSpace event might read wrong free swap space size [v4]
Roman Marchenko
rmarchenko at openjdk.org
Thu Jan 30 08:30:53 UTC 2025
On Fri, 7 Jun 2024 12:10:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> In some cgroups v2 based test system , a too large free swap space value has been observed.
>> The value should not be larger than total swap space.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> add comment suggested by Severin
Yes, I've got the assertion failure when running JTREG tests in a container on a fastdebug build. Created https://bugs.openjdk.org/browse/JDK-8349035
Sorry, I believe this change was wrong: since `OSContainer::memory_and_swap_limit_in_bytes()`, and then `os::total_swap_space()`, can return a negative value, `os::total_swap_space()` call shouldn't be used in `MIN2`. The case is actually processed in the code below the changed line, so I guess necessary changes should be made there, under `if (OSContainer::is_containerized()) { ... `
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19574#issuecomment-2623834432
More information about the hotspot-runtime-dev
mailing list