RFR: 8337548: Parallel class loading can pass is_superclass true for interfaces [v2]

Coleen Phillimore coleenp at openjdk.org
Thu Jan 30 13:08:51 UTC 2025


On Thu, 30 Jan 2025 04:23:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Pass false to check_is_superclass on further thought.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 450:
> 
>> 448:     // Must check ClassCircularity before resolving next_name (superclass or interface).
>> 449:     PlaceholderEntry* probe = PlaceholderTable::get_entry(class_name, loader_data);
>> 450:     if (probe && probe->check_seen_thread(THREAD, PlaceholderTable::DETECT_CIRCULARITY)) {
> 
> Nit pre-existing use of implicit boolean - suggestion `probe != nullptr && ...`

fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23322#discussion_r1935580514


More information about the hotspot-runtime-dev mailing list