Integrated: 8361085: MemoryReserver log_on_large_pages_failure has incorrect format usage
Kim Barrett
kbarrett at openjdk.org
Wed Jul 2 00:28:45 UTC 2025
On Mon, 30 Jun 2025 16:11:47 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this fix of an incorrect format usage.
>
> The function calls `jio_snprintf` to format a message into a buffer. That
> message includes printing a pointer using `PTR_FORMAT`, but isn't using the
> `p2i` helper function. Fixing that is just a matter of using that helper.
>
> However, there's no need to use `jio_snprintf` here, as the resulting message
> is then just passed to `warning`, which can handle output formatting directly.
> So we also move the formatting to the `warning` call, and remove the use of
> `jio_snprintf`. Note that calling `warning` without the `p2i` would have
> produced a compiler warning about the incorrect format usage.
>
> Testing: mach5 tier1
This pull request has now been integrated.
Changeset: 1703915d
Author: Kim Barrett <kbarrett at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/1703915d3fe3608ca558671814f78d9dcf5886e6
Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod
8361085: MemoryReserver log_on_large_pages_failure has incorrect format usage
Reviewed-by: stefank, dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/26050
More information about the hotspot-runtime-dev
mailing list