RFR: 8361383: LogFileStreamOutput::write_decorations uses wrong type for format precisions

David Holmes dholmes at openjdk.org
Fri Jul 4 02:01:39 UTC 2025


On Fri, 4 Jul 2025 00:13:15 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to LogFileStreamOutput to fix the type of the
> precision values used when writing the decorations in a log message.
> 
> While I was at it, value-initialize the _decorator_padding in the
> ctor-initializer rather than with a zero-filling loop.
> 
> Testing: mach5 tier1
> Locally ran several tests that generate logging output and checked by eye the
> decorator output.

Looks good. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26124#pullrequestreview-2985188029


More information about the hotspot-runtime-dev mailing list