RFR: 8356807: Change log_info(cds) to `MetaspaceShared::report_loading_error()` [v2]
Ioi Lam
iklam at openjdk.org
Mon Jul 14 03:38:44 UTC 2025
On Fri, 11 Jul 2025 23:38:53 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> The patch changes some of the `aot_log_info(aot)()` to `MetaspaceShared::report_loading_error()` for those referring to an error condition during loading of AOT cache or CDS archive.
>>
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> update ServiceLoaderTest.java
LGTM.
I would suggest running tiers 5 and 6 as well, as some test cases may be sensitive to the messages that are printed in the "error" level by `MetaspaceShared::report_loading_error()`
-------------
Marked as reviewed by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26253#pullrequestreview-3014689730
More information about the hotspot-runtime-dev
mailing list