RFR: 8356941: AbstractMethodError in HotSpot Due to Incorrect Handling of Private Method [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Jul 15 15:44:40 UTC 2025
On Tue, 15 Jul 2025 00:52:54 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Private methods should never be considered as the implementation of a default method.
>>
>> The first commit adds some additional logging I used to track down what was happening. I like it, but if reviewers think it too much I can drop it.
>>
>> The second commit is the actual fix to exclude private methods, and adds the missing test case to the existing defmeth tests.
>>
>> Testing:
>> - tiers 1-4
>>
>> Thanks
>
> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into 8356941-defaultmeth
> - Merge branch 'master' into 8356941-defaultmeth
> - Fix bug and add new testcases
> - Additional logging to identify the problem
I think the logging gets in the way of understanding the code.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26302#pullrequestreview-3021035104
More information about the hotspot-runtime-dev
mailing list