RFR: 8356807: Change log_info(cds) to `MetaspaceShared::report_loading_error()` [v3]

Tue Jul 15 15:56:40 UTC 2025

On Tue, 15 Jul 2025 04:24:56 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> The patch changes some of the `aot_log_info(aot)()` to `MetaspaceShared::report_loading_error()` for those referring to an error condition during loading of AOT cache or CDS archive.
>> 
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update ArchivedModuleWithCustomImageTest.java

LGTM! Just one nit below

src/hotspot/share/cds/filemap.cpp line 2021:

> 2019:   if (prop != nullptr) {
> 2020:     if (has_aot_linked_classes()) {
> 2021:       MetaspaceShared::report_loading_error("%s has aot-linked classes. It cannot be used when the "

The alignment was changed here.

-------------

Marked as reviewed by matsaave (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26253#pullrequestreview-3021074032
PR Review Comment: https://git.openjdk.org/jdk/pull/26253#discussion_r2207905581