RFR: 8356807: Change log_info(cds) to `MetaspaceShared::report_loading_error()` [v3]

Calvin Cheung ccheung at openjdk.org
Tue Jul 15 16:13:39 UTC 2025


On Tue, 15 Jul 2025 15:53:07 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update ArchivedModuleWithCustomImageTest.java
>
> src/hotspot/share/cds/filemap.cpp line 2021:
> 
>> 2019:   if (prop != nullptr) {
>> 2020:     if (has_aot_linked_classes()) {
>> 2021:       MetaspaceShared::report_loading_error("%s has aot-linked classes. It cannot be used when the "
> 
> The alignment was changed here.

Line 2022 already ends at column 115. If I indent it more to the right to align with line 2021, the line will end past column 125. I will leave it as is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26253#discussion_r2207942311


More information about the hotspot-runtime-dev mailing list