RFR: 8356941: AbstractMethodError in HotSpot Due to Incorrect Handling of Private Method [v2]

[David Holmes]

On Tue, 15 Jul 2025 15:41:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8356941-defaultmeth
>>  - Merge branch 'master' into 8356941-defaultmeth
>>  - Fix bug and add new testcases
>>  - Additional logging to identify the problem
>
> I think the logging gets in the way of understanding the code.  It makes the code hard to read.

Thanks for looking at this @coleenp !

> I think the logging gets in the way of understanding the code. It makes the code hard to read.

I don't disagree. Unfortunately to get the indentation working we need to use a very verbose form of the logging code - and there is lots of duplication. It may be possible to introduce a helper function, but it will still be quite intrusive.

That said I found the logging invaluable when trying to understand why the wrong method was being executed. Though that said the logging is still far from complete in terms of getting a full understanding of how things are processed - I had to add a lot more in my local repo to do the additional experiments today.

So I will remove the logging (and just stash my changes locally for next time).

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26302#issuecomment-3077212874