RFR: 8359339: applications/jcstress tests should report SkippedException when can not resolve jcstress.jar
David Holmes
dholmes at openjdk.org
Thu Jul 17 01:08:49 UTC 2025
On Wed, 16 Jul 2025 08:02:42 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
>
> I think it's more elegant that applications/jcstress tests report SkippedException when can not resolve jcstress.jar, rather than report test failure. Change has been verified locally, test-fix only, no risk.
>
> Tests:
>
> - [x] Run test test/hotspot/jtreg/applications/jcstress/countdownlatch.java with -Djdk.test.lib.artifacts.jcstress-tests-all=/hygonjdk/yansendao/software/jdk/jcstress-tests-all-20241217-2035.jar, test run success as expected.
> - [x] Run test test/hotspot/jtreg/applications/jcstress/countdownlatch.java without -Djdk.test.lib.artifacts.jcstress-tests-all=/hygonjdk/yansendao/software/jdk/jcstress-tests-all-20241217-2035.jar, test report shipped as expected.
I don't agree. If the jar is not found then you have a configuration/setup error. You need to know that. An Error makes you aware of the problem. Skipping won't be noticed unless you analyze SkippedException the same way you analyze errors - in which case just keep it an error.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26345#issuecomment-3082023810
More information about the hotspot-runtime-dev
mailing list