RFR: 8362501: Update test/hotspot/jtreg/applications/jcstress/README [v2]
SendaoYan
syan at openjdk.org
Fri Jul 18 06:31:37 UTC 2025
On Fri, 18 Jul 2025 02:10:47 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update README
>
> test/hotspot/jtreg/applications/jcstress/README line 31:
>
>> 29: successfully. Before you start these tests, you should get the specified
>> 30: build of org.openjdk.jcstress:jcstress-tests-all, the quickest way of
>> 31: get specified build is download the prebuilt JAR from
>
> Suggestion:
>
> successfully. Before you start these tests, you should get the specified
> build of org.openjdk.jcstress:jcstress-tests-all. The quickest way to
> get the specified build is to download the prebuilt JAR from
Thanks for the patiently reviews. @dholmes-ora
The PR has been updated.
> test/hotspot/jtreg/applications/jcstress/README line 35:
>
>> 33: You should specific the JAR location with jtreg option such as
>> 34: -Djdk.test.lib.artifacts.jcstress-tests-all=jcstress-tests-all-20241217-2035.jar
>> 35: when start jcstress tests in jtreg.
>
> Suggestion:
>
> You should specify the JAR location by passing the following property when invoking jtreg. For example:
> -Djdk.test.lib.artifacts.jcstress-tests-all=jcstress-tests-all-20241217-2035.jar
>
> Though I'm unclear if this is a setting passed directly to jtreg, or whether it should be set via e.g. `-javaoption:-Dxxx` ?
I think use `-javaoption:` as prefix will be more expert, though use only -Dxxx will work also. PR has been updated, and I split this line to two lines.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26369#discussion_r2215083436
PR Review Comment: https://git.openjdk.org/jdk/pull/26369#discussion_r2215088674
More information about the hotspot-runtime-dev
mailing list