RFR: 8359820: Improve handshake/safepoint timeout diagnostic messages [v3]

[Anton Artemov]

On Fri, 18 Jul 2025 08:02:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8359820: Addressed reviewer's comments
>
> src/hotspot/share/utilities/vmError.cpp line 827:
> 
>> 825:         } else {
>> 826:           st->print(" (sent by kill)");
>> 827:         }
> 
> I don't understand.
> 
> Should not the receiving thread be the timeouted thread? So the one that is executing right now?

I think it can be that the receiving thread does not manage to report the error, but `safepointTimedOutThread` already got a value, which could confuse the reporting method of `VMError` called on another thread. I think this check is needed, as pointed out by @dholmes-ora .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26309#discussion_r2215489017