RFR: 8359820: Improve handshake/safepoint timeout diagnostic messages [v3]

[Anton Artemov]

On Fri, 18 Jul 2025 07:59:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8359820: Addressed reviewer's comments
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 1351:
> 
>> 1349: // Indicate VMError::report() that SIGILL came from safepoint timeout handler, report which thread timed out
>> 1350: extern intptr_t safepointTimedOutThread;
>> 1351: 
> 
> Do we really need this in globalDefinitions? This seems to be a mechanism highly specific to error handling and safe points.

No, we do not, it seemed like a good place for this "communicative" variables to be declared, but it can be done in safepoint.hpp and handshake.hpp respectively. Addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26309#discussion_r2215521987