RFR: 8359820: Improve handshake/safepoint timeout diagnostic messages [v5]

Thomas Stuefe stuefe at openjdk.org
Fri Jul 18 15:35:49 UTC 2025


On Fri, 18 Jul 2025 15:10:35 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Hi, please consider the following changes:
>> 
>> The problem in the issue description is not a problem by itself, the behavior is not unexpected, but it is somewhat difficult to find out what caused SIGILL to be fired.
>> 
>> We propagate this information from `handshake::handle_timeout()` to `VMError::report()` with a help of a global variable.  The same mechanism is used to address a similar issue in the safepoint timeout handler. 
>> 
>> Tested in tiers 1-3.
>
> Anton Artemov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8359820: Fixed spaces
>  - 8359820: Addressed reviewer's comments

Ok thanks.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26309#pullrequestreview-3033992856


More information about the hotspot-runtime-dev mailing list