RFR: 8356941: AbstractMethodError in HotSpot Due to Incorrect Handling of Private Method [v5]
Coleen Phillimore
coleenp at openjdk.org
Mon Jul 21 21:12:26 UTC 2025
On Sun, 20 Jul 2025 22:47:02 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Private methods should never be considered as the implementation of a default method.
>>
>> The first commit adds some additional logging I used to track down what was happening. I like it, but if reviewers think it too much I can drop it.
>>
>> The second commit is the actual fix to exclude private methods, and adds the missing test case to the existing defmeth tests.
>>
>> Testing:
>> - tiers 1-4
>>
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> typo
I'm a bit happier that the comment is now not duplicated, since neither was helpful to me. This new comment is better.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26302#pullrequestreview-3039867782
More information about the hotspot-runtime-dev
mailing list