RFR: 8364114: Test TestHugePageDecisionsAtVMStartup.java#LP_enabled fails when no free hugepage [v3]

SendaoYan syan at openjdk.org
Sat Jul 26 04:33:20 UTC 2025


On Fri, 25 Jul 2025 13:44:53 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make explicitAvailableHugePageNumber as a member of HugePageConfiguration
>
> test/lib/jdk/test/lib/os/linux/HugePageConfiguration.java line 186:
> 
>> 184:         return 0;
>> 185:     }
>> 186: 
> 
> Can you do it a bit more like the rest of the class - read this info in readFromOS and store it in a member? Print it with toString()? Then we see it in the test output, could be useful. But it cannot be part of the equals() comparison, I think, since there is no direct counterpart on the JVM-side log.

PR has been updated as 'Make explicitAvailableHugePageNumber as a member of HugePageConfiguration'

The tests test/hotspot/jtreg/runtime/os/TestHugePageDetection.java test/hotspot/jtreg/runtime/os/TestHugePageDecisionsAtVMStartup.java test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java test/hotspot/jtreg/gc/z/TestAllocateHeapAt.java has been verified locally.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26480#discussion_r2232548981


More information about the hotspot-runtime-dev mailing list