RFR: 8364197: G1: Sort G1 mutex locks by name and group them together
Thomas Schatzl
tschatzl at openjdk.org
Tue Jul 29 07:42:54 UTC 2025
On Mon, 28 Jul 2025 15:47:22 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> That looks nice. Looks like you alphabetized them also. You could have ordered the ones in mutexLocker.cpp by rank.
Which hunk do you mean? The one assigning the `nullptr` or the initialization using the macros? For the latter, all other locks were separated based on the macro (`MUTEX_DEFN`/`MUTEX_DEFL`) so I kept that.
Other than that I prefer alphabetic ordering. Makes it easier to see which one is missing if you forget one....
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26508#issuecomment-3131100081
More information about the hotspot-runtime-dev
mailing list